fix: handle empty queries safely, ensure golden execution, and parse config robustly#265
Open
aseering wants to merge 11 commits intoGoogleCloudPlatform:mainfrom
Open
fix: handle empty queries safely, ensure golden execution, and parse config robustly#265aseering wants to merge 11 commits intoGoogleCloudPlatform:mainfrom
aseering wants to merge 11 commits intoGoogleCloudPlatform:mainfrom
Conversation
aseering
force-pushed
the
fix-execution-bugs
branch
3 times, most recently
from
72a75ce to
67e7bf3
Compare
aseering
force-pushed
the
fix-execution-bugs
branch
from
67e7bf3 to
872f980
Compare
IsmailMehdi
previously approved these changes
Mar 24, 2026
…tyle Removed several unnecessary blank lines within the client pytest fixture and above it in evalbench/test/mongodb_test.py to resolve an E303 too many blank lines (2) linter failure reported by pycodestyle.
Adjusted spacing before the client fixture and its comment block to satisfy PEP 8 / pycodestyle requirements.
mahyareb
previously approved these changes
Apr 1, 2026
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
mahyareb
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the config-parsing and SQL-execution code to more-defensively handle bad inputs, partial inputs, and other sorts of issues and irregularities with data and config files.